-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): permit to define kube-controller-manager and kube-scheduler resources #16605
Conversation
Hi @chubchubsancho. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e1379c3
to
e857dec
Compare
/ok-to-test |
…cheduler resources Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
e857dec
to
cb75d8a
Compare
Thanks @chubchubsancho! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…f-#16605-upstream-release-1.29 Automated cherry pick of #16605: feat(components): permit to define kube-controller-manager
…f-#16605-upstream-release-1.28-1718010241 Automated cherry pick of #16605: feat(components): permit to define kube-controller-manager
What this PR does / why we need it:
Add ability to define custom resources for
kube-controller-manager
andkube-scheduler
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):fixes #16604
Special notes for your reviewer: