Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): permit to define kube-controller-manager and kube-scheduler resources #16605

Conversation

chubchubsancho
Copy link
Contributor

What this PR does / why we need it:

Add ability to define custom resources for kube-controller-manager and kube-scheduler

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

fixes #16604

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chubchubsancho. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chubchubsancho chubchubsancho force-pushed the feat/cluster/resources_config_for_controller-manager_and_scheduler branch from e1379c3 to e857dec Compare June 6, 2024 20:30
@hakman
Copy link
Member

hakman commented Jun 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2024
…cheduler resources

Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
@chubchubsancho chubchubsancho force-pushed the feat/cluster/resources_config_for_controller-manager_and_scheduler branch from e857dec to cb75d8a Compare June 7, 2024 06:56
@hakman
Copy link
Member

hakman commented Jun 8, 2024

Thanks @chubchubsancho!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2024
@hakman
Copy link
Member

hakman commented Jun 8, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 02a458d into kubernetes:master Jun 8, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jun 8, 2024
@chubchubsancho chubchubsancho deleted the feat/cluster/resources_config_for_controller-manager_and_scheduler branch June 10, 2024 07:43
k8s-ci-robot added a commit that referenced this pull request Jun 11, 2024
…f-#16605-upstream-release-1.29

Automated cherry pick of #16605: feat(components): permit to define kube-controller-manager
k8s-ci-robot added a commit that referenced this pull request Jun 11, 2024
…f-#16605-upstream-release-1.28-1718010241

Automated cherry pick of #16605: feat(components): permit to define kube-controller-manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to define resources for controller manager and scheduler
3 participants