Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golang to 1.22.5 #16649

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jul 4, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 932953c into kubernetes:master Jul 4, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jul 4, 2024
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2024
…49-upstream-release-1.30

Automated cherry pick of #16649: chore: update golang to 1.22.5
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2024
…49-upstream-release-1.29

Automated cherry pick of #16649: chore: update golang to 1.22.5
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2024
…49-upstream-release-1.28

Automated cherry pick of #16649: chore: update golang to 1.22.5
@upodroid
Copy link
Member

upodroid commented Jul 6, 2024

You forgot to bump the go version on cloudbuild and we haven't had a passing build on master since this PR merged.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/kops-postsubmit-push-to-staging/1809003660097622016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants