Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2708 broken kubernetes-dashboard due to RBAC #2949

Merged
merged 1 commit into from Jul 15, 2017
Merged

Fixes #2708 broken kubernetes-dashboard due to RBAC #2949

merged 1 commit into from Jul 15, 2017

Conversation

BradErz
Copy link
Contributor

@BradErz BradErz commented Jul 15, 2017

Added cluster role binding which uses the cluster-admin role (updated using https://git.io/kube-dashboard as a template)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @BradErz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BradErz BradErz mentioned this pull request Jul 15, 2017
Closed
@justinsb
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2017
justinsb
justinsb approved these changes Jul 15, 2017
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2017
@justinsb
Copy link
Member

Thanks @BradErz - I'll merge on green - or maybe before as I accidentally broke head just before you sent this PR :-)

@justinsb justinsb merged commit f7e8950 into kubernetes:master Jul 15, 2017
@BradErz
Copy link
Contributor Author

BradErz commented Jul 15, 2017

@justinsb hahah i think it was probally my bad.... i was running an outdated local in the pull request...

@gianrubio
Copy link
Contributor

This was already discussed on #2789
The conclusion was to not give the full permission to kubernetes-dashboard and just add a note on the Readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb approved these changes

Assignees

@justinsb justinsb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BradErz @k8s-ci-robot @justinsb @gianrubio