Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error messages with docker api #3034

Merged

Conversation

chrislovecnm
Copy link
Contributor

Got `DOCKER_HOST="unix:///var/run/docker.sock" running on my mac. I do not have the time to try to figure out how to make socket connection, but the error message will help a user.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2017
@justinsb
Copy link
Member

Looks like docker changed the default, it is now https://github.com/docker/engine-api/blob/master/client/client_unix.go but in the version we're using Darwin is

// DefaultDockerHost defines os specific default if DOCKER_HOST is unset
const DefaultDockerHost = "tcp://127.0.0.1:2375"

(unix is DefaultDockerHost = "unix:///var/run/docker.sock")

Probably going to be best to use the Docker CLI throughout :-(

@chrislovecnm
Copy link
Contributor Author

Would be better in mind to use the socket, I would rather now have to have the binary in a k8s hosted kops. Just a thought

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2017
@justinsb
Copy link
Member

justinsb commented Aug 4, 2017

Yes, I definitely favor the socket as well. Except that using the socket means parsing the auth values ourselves, which is a pain. So we end up using the CLI for push & pull anyway. I'm thinking we just use the CLI everywhere, for now...

@justinsb justinsb self-assigned this Aug 4, 2017
@justinsb
Copy link
Member

Although this is an improvement on the API path, whether or not we want that long term :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [chrislovecnm,justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e51aa03 into kubernetes:master Aug 11, 2017
@chrislovecnm chrislovecnm deleted the docker-api-messages branch December 30, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants