Ignore shared services (vpcs, subnets) showing up in a dry-run

[KashifSaadat]

The short block of code checks for the existence of a Shared field (present on the shared resource types vpc and subnet) with a bool value true and skips it.

Fixes: #476

[k8s-ci-robot]

Hi @KashifSaadat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KashifSaadat
We suggest the following additional approver: zmerlynn

Assign the PR to them by writing /assign @zmerlynn in a comment when ready.

Associated issue: 476

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[KashifSaadat]

/assign @chrislovecnm

[justinsb]

Is this just the name for you - I've been meaning to fix that for a long time. Or are there other things also changing that you want to ignore?

The reason being that I would like to preserve the ability to warn about differences in shared objects, so that we can diagnose clusters that may be misconfigured. I don't yet know if skipping over shared objects entirely is the right thing to do there, TBH.

I think the first step here (if it's the name) is just to fix the Name bug. I thought I had a fix on one of my branches so I'll try to dig it up.

[KashifSaadat]

Hey @justinsb. It was the Name & Tags that were highlighted for change. Warning about differences would be better, happy to hold this back if you have a PR for it. 👍

[KashifSaadat]

Closing in favour of #3184