Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wildcard domains returned as ASCII in dns-controller #3110

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Aug 1, 2017

After running into #2671 whenever dns-controller restarted, I looked into why dns-controller successfully creates entries for wildcard domains (e.g. *.example.com ) but after restarting, it errors, unable to find the old record. It looks amazon returns ascii \\052.example.com instead of the *.example.com we expect. This was a simple fix I tested in our cluster and it seems to have fixed the issue. I'm open to any changes but I think this could be a useful fix for those that may run into this in the future.

This isn't a new thing apparently: boto/boto#818

Fixes #2671

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mikesplain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikesplain
Copy link
Contributor Author

/assign @kris-nova

@justinsb
Copy link
Member

justinsb commented Aug 2, 2017

/lgtm

Thanks @mikesplain

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2017
@mikesplain
Copy link
Contributor Author

Great! Thanks for taking a look @justinsb!

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b40320a into kubernetes:master Aug 2, 2017
@mikesplain mikesplain deleted the FixWildcards branch August 2, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS for api.internal not updated after doing a rolling update when a LoadBalancer service has a Route 53 entry
5 participants