-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kube Proxy Feature Gates #3130
Kube Proxy Feature Gates #3130
Conversation
gambol99
commented
Aug 3, 2017
- fixing the kubeproxy feature gates, this should have been a map not an array ... apologizes!! from
Hi @gambol99. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- fixing the kubeproxy feature gates, this should have been a map not array (https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/v1alpha2/componentconfig.go#L134)
/ok-to-test /lgtm In general, we actually can't change these once we've shipped them: we have to create a new API version, and convert back and forth. However in this case it didn't make it into a release, and it isn't in a top-level object (i.e. we don't really expect most users to be setting them), so I think it's fine. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |