CoreOS: Ensure docker configuration is loaded

[johanneswuerbach]

Previously the configuration has been written after docker has been started and
was actually only applied after a reboot.

Manually reload system and restart docker to ensure the configuration has been
applied.

[k8s-ci-robot]

Hi @johanneswuerbach. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[johanneswuerbach]

@justinsb not really fan of manually restarting docker here, but couldn't find a better way without introducing further changes.

[johanneswuerbach]

/assign @chrislovecnm

[johanneswuerbach]

/assign @justinsb

[justinsb]

There's some overly-elaborate logic for automatically restarting systemd services when it is needed, but we're not hitting that in this case because we're not managing the systemd service itself: https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/nodeup/nodetasks/service.go#L223

I don't think there is anything wrong with what you've done. We have the logic for automatically restarting the service so we can restart it only once (and so that it is automatic), but I'll ponder if we can do something nicer. We may be able to hook in to the service-restart phase, for example. But I'm not sure it'll be noticeably better than the obvious and obviously-correct approach you've taken (obvious is good!).

[johanneswuerbach]

Thanks, if there is something I can change, I'll happily do so :-)

[justinsb]

/ok-to-test

So maybe we could tweak the service task to (optionally) not control the service definition. We have something comparable at the moment, with ManageState - though that determines whether we start/restart the service, rather than whether we manage the definition.

Given that, I say we get it in - if there are issues or we can do better in future, we can deal with that.

Thanks @johanneswuerbach !

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johanneswuerbach, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue