-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Canal Taints and Tolerations #3142
Fix for Canal Taints and Tolerations #3142
Conversation
Hi @prachetasp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @justinsb |
/ok-to-test This is good, but in order to get this to be applied to existing clusters, you also need to update the version of the manifest here: https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L416 Anything "higher" than the existing should work, if the calico version is 1.3.0 we should probably use that value, for sanity! |
Bumped the Canal manifest addon version as suggested. Thanks for pointing that out! |
/lgtm Thanks @prachetasp |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, prachetasp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
This PR fixes issues with taints and tolerations for the Canal network type.
There are 2 problems:
When using these fixes to boot our k8s 1.7.3 cluster with this branch the Taints showed up and Calico scheduled on our masters and our dedicated IG.
I am not sure if there are associated tests that need to be updated here - still not familiar enough with the kops repo to tell.