Rework legacy validation to use field error helpers #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
This was referenced Aug 5, 2017
Merged
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
KashifSaadat
reviewed
Aug 7, 2017
pkg/apis/kops/validation/legacy.go
Outdated
| } | ||
| if strict && c.Spec.Kubelet == nil { | ||
| return fmt.Errorf("Kubelet not configured") | ||
| return field.Required(fieldSpec.Child("Kubelet"), "Kubelet not configured") |
There was a problem hiding this comment.
Looks like this is already validated on L78
|
One small pre-existing validation check that can be removed, otherwise LGTM. 👍 |
|
Going to rebase this after etcd3 support (#3176) lands |
justinsb
force-pushed
the
validation_cleanup
branch
from
2a48df7
to
f9f8769
Compare
k8s-github-robot
removed
the
needs-rebase
justinsb
force-pushed
the
validation_cleanup
branch
from
f9f8769
to
9c5d4c2
Compare
justinsb
added
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.