New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SSL in ELB API server health check #3151
Use SSL in ELB API server health check #3151
Conversation
Hi @johanneswuerbach. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This switch causes the ELB to perform a SSL handshake and makes the `I0427 03:57:55.059255 1 logs.go:41] http: TLS handshake error from IP:PORT: EOF` disappear from the apiserver logs.
ed8ba51
to
2accc73
Compare
/assign @justinsb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, johanneswuerbach The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
This switch causes the ELB to perform a SSL handshake and makes the
I0427 03:57:55.059255 1 logs.go:41] http: TLS handshake error from IP:PORT: EOF
disappear from the apiserver logs.
Tested manually and everything looks ✅
Inspiration from kubernetes-retired/kube-aws#604