Fix dropped error in kops cmd package #3175
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @alrs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-ok-to-test
|
/approve |
|
/assign @justinsb |
| @@ -138,6 +138,9 @@ func RunGet(context Factory, out io.Writer, options *GetOptions) error { | |||
| args := make([]string, 0) | |||
|
|
|||
| clusters, err := buildClusters(args, clusterList) | |||
| if err != nil { | |||
| return fmt.Errorf("error on buildClusters(): %v", err) | |||
There was a problem hiding this comment.
Just a note/nitpick
BTW really appreciate you fixing all of these!!!
In the future, if we can do human readable error messages, meaning "building the cluster" failed.
|
/approve no-issue |
k8s-ci-robot
removed
the
needs-ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alrs, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This fixes a dropped error variable in the kops cmd package.