Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Keyset API type #3286

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Create Keyset API type #3286

merged 2 commits into from
Sep 6, 2017

Conversation

justinsb
Copy link
Member

A Keyset holds a set of keypairs or other secret cluster material.

It is a set to support rotation of keys.

This will allow us to store secrets on kops-server (and also is a step towards
separating where we manage secrets from how we communicate them to running
clusters, which will allow bare-metal or KMS)

Starting with just the API objects.

@justinsb
Add Keyset API type
8792323 
This will allow management of cluster secrets in kops-server
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2017
@justinsb
Copy link
Member Author

Splitting up #3150 - should get us cluster rotation, bare metal & kops server support at the end of the road.

@chrislovecnm it's a long path, but can you have a look please?

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2017
chrislovecnm
chrislovecnm suggested changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain if we are not getting code comments because the code was generated, or if you missed some. Not a huge fan or the name, but I cannot think of anything else.

pkg/client/clientset_generated/clientset/typed/kops/internalversion/kops_client.go
@@ -46,6 +47,10 @@ func (c *KopsClient) InstanceGroups(namespace string) InstanceGroupInterface {
return newInstanceGroups(c, namespace)
}

func (c *KopsClient) Keysets(namespace string) KeysetInterface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need code comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated

pkg/client/clientset_generated/clientset/typed/kops/v1alpha2/fake/fake_keyset.go

var keysetsKind = schema.GroupVersionKind{Group: "kops", Version: "v1alpha2", Kind: "Keyset"}

func (c *FakeKeysets) Create(keyset *v1alpha2.Keyset) (result *v1alpha2.Keyset, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this generated? If not we need code comments please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated

pkg/apis/kops/v1alpha2/keyset.go

// +genclient=true

// Keyset is a set of system keypairs, or other secret material.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to regen the api docs as well, but another PR.

@chrislovecnm
Copy link
Contributor

Been super busy. Have not had a chance to look at the other PR yet ...

@justinsb
Copy link
Member Author

justinsb commented Sep 2, 2017

So I think you reviewed the generated code - it's only 8792323 that really needs attention.

LGTM therefore?

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [chrislovecnm,justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@justinsb
Copy link
Member Author

justinsb commented Sep 6, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 31e7fbf into kubernetes:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm requested changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-review size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @chrislovecnm @k8s-github-robot @k8s-ci-robot