Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbox template #3287

Merged
merged 2 commits into from
Sep 10, 2017
Merged

Toolbox template #3287

merged 2 commits into from
Sep 10, 2017

Commits on Sep 8, 2017

  1. Toolbox Templating 

    Extending the current implementation of toolbox template to include multiple files and snippets. Note, i've removed the requirements for defaults as I think people should be forced to specifically pass them.

- fixing the vetting iseues to the method YamlToJson -> YAMLToJSON
- adding a safety check to ensure templates don't reference an unknown value
- extending the unit test to ensure the above works on main and snippets
- include the ability to specify multiple configuration files, useful for common.yaml and prod.yaml etc

Requested Changes - Toolbox Templating

Added the requested changes

- moved the templater into it's own package rather than using base util
- moved to using the sprig library for additional template function
- @note: i couldn't find a native way in sprig to do snippets, also the i've overloaded the indent as it appears to do the indent on all lines rather than on the newline, meaning i'd have to shift my first line back by the indent to get it to work, which seems ugly
    @gambol99
    gambol99 committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    aaf6143 View commit details
    Browse the repository at this point in the history

  2. Vendoring / Dependencies 

    Adding the dependecies for the templating
    @gambol99
    gambol99 committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    404d940 View commit details
    Browse the repository at this point in the history