Implementing GCE as an interface - modelling aws cloud provider #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
approved
k8s-ci-robot
added
the
size/L
|
/assign @andrewsykim @gambol99 @KashifSaadat Only need one of you guys to review, whoever gets there first wins :) |
|
Built a cluster ... looks good. |
|
LGTM! |
KashifSaadat
approved these changes
Aug 28, 2017
|
/lgtm What are you up to @chrislovecnm ? :-) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
@justinsb eventually having rolling update work with GCE ;) |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Sep 4, 2017
Fix regression in kubernetes#3292
This was referenced Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCE and other cloud providers are structs instead of an interface. AWS cloud provider implements an interface. This PR refactors
GCECloudas an interface, and createsgceCloudImplementation.