Misc go vet fixes #3307
Merged
Misc go vet fixes #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
the
approved
gambol99
reviewed
Aug 29, 2017
| @@ -97,12 +97,12 @@ func TestPrivateKopeio(t *testing.T) { | |||
| runTest(t, "privatekopeio.example.com", "../../tests/integration/privatekopeio", "v1alpha2", true, 1) | |||
| } | |||
|
|
|||
| // TestPrivateDns runs the test on a configuration with private topology, private dns | |||
| // TestPrivateDns1 runs the test on a configuration with private topology, private dns | |||
There was a problem hiding this comment.
not sure it's necessary on unit tests
gambol99
reviewed
Aug 29, 2017
| @@ -41,7 +41,7 @@ func TestCreateClusterMinimal(t *testing.T) { | |||
| runCreateClusterIntegrationTest(t, "../../tests/integration/create_cluster/minimal", "v1alpha2") | |||
| } | |||
|
|
|||
| // TestCreateClusterMinimal runs kops create cluster, with a grab-bag of edge cases | |||
| // TestCreateClusterComplex runs kops create cluster, with a grab-bag of edge cases | |||
There was a problem hiding this comment.
does go-vet complain of test files now?
|
lgtm |
|
/retest |
|
@gambol99 you had open questions but nothing that I perceive as blocking merge. Correcf? /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.