Check actual EbsOptimized status during cluster update

[Pharb]

Fixes #3313.

It seems like the actual EbsOptimized state of the LaunchConfiguration is not read during kops update cluster and always trigges a modification of instance-groups that have rootVolumeOptimization: true.

If any meaningful test can be created for this, please let me know.

[k8s-ci-robot]

Hi @Pharb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Pharb]

/assign @justinsb

[chrislovecnm]

@Pharb not really something that is unit tested easily. I assume that you have run your own e2e tests locally.

/ok-to-test

[Pharb]

Yes, I did test this change with my own cluster on AWS and can confirm that this fixes the problem described in #3313 for me.
Additionally I backported the fix to the release-1.7 branch and it also worked like expected.

[chrislovecnm]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pharb, chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [chrislovecnm]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[justinsb]

Nice fix - thank you @Pharb

[justinsb]

/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue