Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in aws.md #3324

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Fix broken link in aws.md #3324

merged 1 commit into from
Sep 2, 2017

Conversation

BlueMonday
Copy link
Contributor

aws.md linked to advanced_create.md which was deleted in
#2725. Its contents were added to
high_availability.md. Update the link to point to the relevant section in
high_availability.md.

@BlueMonday
Fix broken link in aws.md
a7d2907 
aws.md linked to advanced_create.md which was deleted in
#2725. Its contents were added to
high_availability.md. Update the link to point to the relevant section in
high_availability.md.

Signed-off-by: Steven Santos Erenst <stevenerenst@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @BlueMonday. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2017
@BlueMonday
Copy link
Contributor Author

/assign @kris-nova

@sethpollack
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@chrislovecnm
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlueMonday, chrislovecnm, sethpollack

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@BlueMonday
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@BlueMonday: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Member

justinsb commented Sep 2, 2017

/retest

@justinsb
Copy link
Member

justinsb commented Sep 2, 2017

(We just cut the kubernetes build, and we're having trouble with the k8s tests, so don't worry if the tests don't pass - we'll get it in once the tests are happy again)

Thanks for the PR @BlueMonday

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit bd3daf4 into kubernetes:master Sep 2, 2017
@clenimar clenimar mentioned this pull request Oct 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sethpollack sethpollack

@krisnova krisnova

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BlueMonday @k8s-ci-robot @sethpollack @chrislovecnm @k8s-github-robot @justinsb @krisnova