DNS Controller Limitation #3330
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
@KashifSaadat .. can i have a review please :-) |
gambol99
force-pushed
the
limit_dns_controller
branch
from
589e6e0
to
c52456b
Compare
|
/test pull-kops-e2e-kubernetes-aws |
|
/retest |
1 similar comment
|
/retest |
|
grumble grumble testing ... /retest
|
k8s-github-robot
added
the
needs-rebase
|
@gambol99 PR needs rebase |
|
/lgtm Nice change, but needs a rebase it looks like. I believe our tests are (finally) happy again :-) |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
|
/retest |
|
@gambol99 probably need a rebase on this. E2E seems to be running tonight |
|
@gambol99 can we get a rebase? |
The current implementation does not place any limitation on the dns annontation which the dns-controller can consume. In a multi-tenented environment was have to ensure certain safe guards are met, so users can't byt accident or intentionally alter our internal dns. Note; the current behaviour has not been changed; - added the --watch-namespace option to the dns controller and WatchNamespace to the spec - cleaned up area of the code where possible or related - fixed an vetting issues that i came across on the journey - renamed the dns-controller watcher files
gambol99
force-pushed
the
limit_dns_controller
branch
from
c52456b
to
b647956
Compare
k8s-github-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. . |
The current implementation does not place any limitation on the dns annontation which the dns-controller can consume. In a multi-tenented environment we have to ensure certain safe guards are met, so users can't by accident or intentionally alter our internal dns. Note; the current behaviour has not been changed;