refactor resource tracker to be usable across packages #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
andrewsykim
force-pushed
the
refactor-resource-tracker
branch
from
76ea7e9
to
d9fa618
Compare
|
/lgtm We've been wrestling with the tests today, I did bring up a cluster with the same k8s version (but not this patch) and it did work. But I'd still suspect the tests over an actual failure caused by this PR, at least for now :-) /retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test pull-kops-e2e-kubernetes-aws |
nice! 😛 |
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts ResourceTracker into its own package
pkg/resources/trackerso it can be called from different packges without hitting import cycle e.g.pkg/reources/digitalocean/resource.go. This is so that we can group cloud specific code into their own packages (pkg/resources/aws/.pkg/resources/gce/, etc) rather than dump all the resource code from all clouds intopkg/resources