Makefile clean #3332
Makefile clean #3332
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kops-e2e-kubernetes-aws |
|
/test pull-kops-e2e-kubernetes-aws
…On Sep 2, 2017 11:45 PM, "k8s-ci-robot" ***@***.***> wrote:
@alrs <https://github.com/alrs>: The following test *failed*, say /retest
to rerun them all:
Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 7092411
<7092411>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kops/3332/pull-kops-e2e-kubernetes-aws/2847/> /test
pull-kops-e2e-kubernetes-aws
Full PR test history <https://k8s-gubernator.appspot.com/pr/kops/3332>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/alrs>. Please help us
cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kops/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3332 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABva9srEDz9jjUMjuJGa3NuG0MHlbsUks5seksLgaJpZM4PLDYy>
.
|
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws |
|
@alrs we have an issue with testing framework, which is a known issue. Nothing is passing at this point with kops :( |
|
I saw that this morning, figured I'd git it another try. Is this being
discussed on the kubernetes-dev list, or elsewhere?
…On Mon, Sep 4, 2017 at 7:16 PM, Chris Love ***@***.***> wrote:
@alrs <https://github.com/alrs> we have an issue with testing framework,
which is a known issue. Nothing is passing at this point with kops :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3332 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABva9VCf3XPYoQcLIlkRD9cRin6bTtnks5sfK8IgaJpZM4PLDYy>
.
|
|
@alrs saw dicussion in #sig-release slack and we have an issue in about running out of disk in the aws region in test-infra. The tests are using over 20 TB while running a bunch in ||. |
|
/test pull-kops-e2e-kubernetes-aws |
|
/assign @zmerlynn |
Makefile
Outdated
| @@ -107,6 +109,10 @@ help: # Show this help | |||
| echo ''; \ | |||
| } 1>&2; \ | |||
|
|
|||
| clean: # Remove build directory and bindata-generated files | |||
There was a problem hiding this comment.
Do we need .PHONY for the new targets?
There was a problem hiding this comment.
clean needs to be marked as PHONY, but the two bindata.go files aren't PHONY, so they aren't tagged as such. I'll update the PR.
Makefile move gobindata-tool dependency off individual bindata.go targets and on to the existing kops-gobindata target
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alrs, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
I'm interested in tightening up the kops Makefile.
This first step adds a "clean" recipe for deleting the .build directory and any files generated by go-bindatatool.
The two files generated by go-bindatatool get their own recipes, so now make can keep track of when they have been built and will not need to regenerate.