add autoscaling:DescribeLaunchConfigurations permission

[rushtehrani]

As of 0.6.1, Cluster Autoscaler supports scaling node groups from/to 0, but requires the autoscaling:DescribeLaunchConfigurations permission.

It'd be great to have this in kops since this permission needs to be re-added back to the master policy every time the cluster is updated.

[k8s-ci-robot]

Hi @rushtehrani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rushtehrani]

/assign @chrislovecnm

[justinsb]

/ok-to-test

[KashifSaadat]

LGTM! I've included this within PR #3343 which is a rework of all the IAM policies.

[justinsb]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[justinsb]

Thanks @rushtehrani & sorry for the delay - we had some test infrastructure problems, now resolved (hopefully).

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[chrislovecnm]

/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue

[dmcnaught]

This didn't seem to get into kops 1.7.1. I'm still seeing the problem

[KashifSaadat]

Hi @dmcnaught, kops v1.7.1 only contains a vulnerability fix over v1.7.0. The autoscaling IAM change is included in the following kops release: https://github.com/kubernetes/kops/releases/tag/1.8.0-alpha.1