Prevent Docker build environments from creating root-owned artifacts #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
/test pull-kops-e2e-kubernetes-aws |
|
/test pull-kops-e2e-kubernetes-aws
…On Sep 7, 2017 9:52 PM, "k8s-ci-robot" ***@***.***> wrote:
@alrs <https://github.com/alrs>: The following test *failed*, say /retest
to rerun them all:
Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 5f6751b
<5f6751b>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kops/3354/pull-kops-e2e-kubernetes-aws/2908/> /test
pull-kops-e2e-kubernetes-aws
Full PR test history <https://k8s-gubernator.appspot.com/pr/kops/3354>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/alrs>. Please help us
cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kops/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3354 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABva2fq_gY4pcr80CIDgfkilxJAdvNrks5sgMgJgaJpZM4PQp4j>
.
|
|
/test pull-kops-e2e-kubernetes-aws |
|
/test pull-kops-e2e-kubernetes-aw
…On Fri, Sep 8, 2017 at 11:21 AM, k8s-ci-robot ***@***.***> wrote:
@alrs <https://github.com/alrs>: The following test *failed*, say /retest
to rerun them all:
Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 5f6751b
<5f6751b>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kops/3354/pull-kops-e2e-kubernetes-aws/2911/> /test
pull-kops-e2e-kubernetes-aws
Full PR test history <https://k8s-gubernator.appspot.com/pr/kops/3354>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/alrs>. Please help us
cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kops/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3354 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABva0JRvljd-J1HGms8LYW1qyUy7IdCks5sgYWQgaJpZM4PQp4j>
.
|
|
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
|
/test pull-kops-e2e-kubernetes-aws |
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alrs, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
All the polish you add is seriously appreciated!!!!! |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaries in
.build/artifactsare built in Docker containers and are owned by the root user.I've created HOST_UID and HOST_GID variables in the Makefile that are passed in to the Docker build containers so that artifacts can be chowned to the proper user and group IDs.
Previously, it was impossible to
make cleanorrm -rf .buildwithout root privileges.