Add a doc to describe how to use kops in AWS China #3360

qqshfox · 2017-09-10T04:58:14Z

Closes #2933, closes #3282.

@wangycc, @mgyong, @hb404 This doc might be helpful for you guys to deploy a cluster in AWS China Region.

@chrislovecnm, @justinsb Please help to review. Thanks.

k8s-ci-robot · 2017-09-10T04:58:22Z

Hi @qqshfox. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chrislovecnm

This is amazing!! Bunch of comments. If you want to file an issue and update the changes as needed we can merge before all the changes are done.

chrislovecnm · 2017-09-10T17:14:01Z

docs/aws-china.md

+
+## Getting Started
+
+Kops used to only support Google Cloud DNS and Amazon Route53 to provision a kubernetes cluster. But since 1.6.2 `gossip` has been added which make it possible to provision a cluster without one of those DNS providers. Thanks to `gossip`, it's officially supported to provision a fully-functional kubernetes in AWS China Region [which doesn't have Route53 so far][1] since [1.7][2].


Can we provide the name of the region? Also how much work would it be to get this doc in mandarin?

Also how much work would it be to get this doc in mandarin?

Maybe this weekend or next...

chrislovecnm · 2017-09-10T17:14:42Z

docs/aws-china.md

+
+When `aws configure`, remember to set the `default region name` to the correct one, e.g. `cn-north-1`.
+
+```bash


console may highlight better

chrislovecnm · 2017-09-10T17:16:21Z

docs/aws-china.md

+${GOPATH}/bin/imagebuilder --config aws.yaml --v=8 --publish false --replicate false --up false
+```
+
+*The execution might fail but the AMI will be created successfully.*


Do we have a bug for this?

How do you validate that the ami was created?

chrislovecnm · 2017-09-10T17:17:18Z

docs/aws-china.md

+Set up a few environment variables.
+
+```bash
+export NAME=myfirstcluster.k8s.local


We usually use the words example here in the name.

chrislovecnm · 2017-09-10T17:18:32Z

docs/aws-china.md

+
+### [Create cluster configuration](aws.md#create-cluster-configuration)
+
+We will need to note which availability zones are available to us. AWS China (Beijing) Region only has two availability zones. It will have [the same problem][6], like other regions having less than three AZs, that there is no true HA support.


No capability to run 3 masters with three azs? We may want to note that we can use three masters in one az.

chrislovecnm · 2017-09-10T17:20:36Z

docs/aws-china.md

+
+**Please note that this will still have 50% chance to break the cluster when one of the AZs are down.**
+
+### Offline mode


Should we note that assest API will provide this capability in the future?

You did below

chrislovecnm · 2017-09-10T17:21:08Z

docs/aws-china.md

+
+### Assets API
+
+It hasn't been tested as this approach was only a PR when the author experimenting with provisioning a cluster in AWS China Region. It's the official way to achieve offline mode and should be superior to the previous naive attempt.


Work in progress ;)

chrislovecnm · 2017-09-10T17:21:53Z

docs/aws-china.md

+```bash
+## Setup vars
+
+KUBERNETES_VERSION=v1.7.2


Can we pull from the version file?

chrislovecnm · 2017-09-10T17:22:11Z

docs/aws-china.md

+## Setup vars
+
+KUBERNETES_VERSION=v1.7.2
+KOPS_VERSION=1.7.0


Same can we pull the latest version with curl?

chrislovecnm · 2017-09-10T17:22:32Z

docs/aws-china.md

+ASSET_PREFIX=""
+
+export KOPS_BASE_URL=https://s3.cn-north-1.amazonaws.com.cn/$ASSET_BUCKET/kops/$KOPS_VERSION/
+export CNI_VERSION_URL=https://s3.cn-north-1.amazonaws.com.cn/$ASSET_BUCKET/kubernetes/network-plugins/cni-0799f5732f2a11b329d9e3d51b9c8f2e3759f2ff.tar.gz


Make a note that this changes with k8s version

chrislovecnm · 2017-09-10T20:29:53Z

/ok-to-test

qqshfox · 2017-09-11T07:43:28Z

@chrislovecnm Thank you for your review. I update the changes following your comments. And still keep them in small chunks to be convenient for your eyes. I can squash them into a single commit afterwards if you wish.

chrislovecnm · 2017-09-14T21:05:51Z

Please squash and we can get this in!

Closes kubernetes#2933, kubernetes#3282.

qqshfox · 2017-09-15T00:28:22Z

Squashed.

chrislovecnm · 2017-09-15T01:01:02Z

/lgtm

k8s-github-robot · 2017-09-15T01:01:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [chrislovecnm]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-09-15T01:17:46Z

Automatic merge from submit-queue

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2017

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2017

chrislovecnm suggested changes Sep 10, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2017

chrislovecnm added the retest-not-required-docs-only label Sep 10, 2017

Add a doc to describe how to use kops in AWS China

e9b1648

Closes kubernetes#2933, kubernetes#3282.

qqshfox force-pushed the patch-1 branch from 75a8d0a to e9b1648 Compare September 15, 2017 00:27

k8s-ci-robot assigned chrislovecnm Sep 15, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2017

k8s-github-robot merged commit 4b5d6e4 into kubernetes:master Sep 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a doc to describe how to use kops in AWS China #3360

Add a doc to describe how to use kops in AWS China #3360

qqshfox commented Sep 10, 2017 •

edited

Loading

k8s-ci-robot commented Sep 10, 2017

chrislovecnm left a comment

chrislovecnm Sep 10, 2017

qqshfox Sep 11, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm Sep 10, 2017

chrislovecnm commented Sep 10, 2017

qqshfox commented Sep 11, 2017

chrislovecnm commented Sep 14, 2017

qqshfox commented Sep 15, 2017

chrislovecnm commented Sep 15, 2017

k8s-github-robot commented Sep 15, 2017

k8s-github-robot commented Sep 15, 2017


		## Getting Started

		Kops used to only support Google Cloud DNS and Amazon Route53 to provision a kubernetes cluster. But since 1.6.2 `gossip` has been added which make it possible to provision a cluster without one of those DNS providers. Thanks to `gossip`, it's officially supported to provision a fully-functional kubernetes in AWS China Region [which doesn't have Route53 so far][1] since [1.7][2].


		When `aws configure`, remember to set the `default region name` to the correct one, e.g. `cn-north-1`.

		```bash


		### [Create cluster configuration](aws.md#create-cluster-configuration)

		We will need to note which availability zones are available to us. AWS China (Beijing) Region only has two availability zones. It will have [the same problem][6], like other regions having less than three AZs, that there is no true HA support.


		Please note that this will still have 50% chance to break the cluster when one of the AZs are down.

		### Offline mode


		### Assets API

		It hasn't been tested as this approach was only a PR when the author experimenting with provisioning a cluster in AWS China Region. It's the official way to achieve offline mode and should be superior to the previous naive attempt.

Add a doc to describe how to use kops in AWS China #3360

Add a doc to describe how to use kops in AWS China #3360

Conversation

qqshfox commented Sep 10, 2017 • edited Loading

k8s-ci-robot commented Sep 10, 2017

chrislovecnm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrislovecnm commented Sep 10, 2017

qqshfox commented Sep 11, 2017

chrislovecnm commented Sep 14, 2017

qqshfox commented Sep 15, 2017

chrislovecnm commented Sep 15, 2017

k8s-github-robot commented Sep 15, 2017

k8s-github-robot commented Sep 15, 2017

qqshfox commented Sep 10, 2017 •

edited

Loading