Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateSecurityGroup permission #3362

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Add CreateSecurityGroup permission #3362

merged 1 commit into from
Sep 11, 2017

Conversation

justinsb
Copy link
Member

Also document the available filtering for the methods we use.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2017
@justinsb
Copy link
Member Author

I got tests running which fail against head using the nodeport support (thanks @chrislovecnm), will need to get those changes into kubetest.

So now we're in a position to add the IAM policy again and validate that it does fix tests.

I reviewed and I believe this is the only policy missing.

chrislovecnm
chrislovecnm approved these changes Sep 10, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@chrislovecnm
Copy link
Contributor

CI failed :) fix please then I can lgtm

@chrislovecnm
Copy link
Contributor

Oh and ci failing is good

@justinsb
Add CreateSecurityGroup permission
7b55100 
Also document the available filtering for the methods we use.
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [chrislovecnm,justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5c0ac9d into kubernetes:master Sep 11, 2017
@KashifSaadat KashifSaadat mentioned this pull request Sep 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @chrislovecnm @k8s-github-robot @k8s-ci-robot