Add external-dns as addon.

[haad]

This superseeds route53mapper as it has multicloud support documentation and YAML taken from https://github.com/kubernetes-incubator/external-dns

[k8s-ci-robot]

Hi @haad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chrislovecnm]

Appreciate the PR, but we have external dns built in as a feature flag. Do you mind bumping the interns version? https://github.com/kubernetes/kops/tree/master/upup/models/cloudup/resources/addons/external-dns.addons.k8s.io

Update those two manifests and this file https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

[justinsb]

This is timely - I have been thinking for some of the additional clouds we support, we probably could make external-dns primary. In any case, LGTM :-) I believe there are some functionality gaps for full replacement of all the kops functionality, but let's get the addon created!

/lgtm

/ok-to-test

[justinsb]

Ooops - sorry - @chrislovecnm is right!

/remove lgtm

It would be good to get that addon consumable elsewhere, but we don't want two copies.

[chrislovecnm]

Again we appreciate the help, but just use the feature flag setting to use external dns https://github.com/kubernetes/kops/blob/master/docs/experimental.md

[haad]

I see I will bump internal version in a template. What is not clear to me is if it's possible to pass/define ExternalDnsArgv in cluster.spec

[chrislovecnm]

ExternalDnsArgv is a func in our templater. On my phone so I cannot look it up easily.

[chrislovecnm]

Can we get this moved to docs folder, and mention the feature flag?

[chrislovecnm]

@haad

kops/upup/pkg/fi/cloudup/template_functions.go

Line 206 in e559471

func (tf *TemplateFunctions) ExternalDnsArgv() ([]string, error) {

is where ExternalDNS lives. What changes do we need to make??

[blakebarnett]

Would love to see external-dns be made primary especially if we don't want to keep fixing all the issues with dns-controller (it hates sharing control of records with anything else, can't deal with multiple duplicate annotations, etc.)

[justinsb]

So as it stands now this is a version upgrade - the docs probably will be more discoverable somewhere else, but we can do that in another PR if you agree :-)

Thanks @haad !

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. .