Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile remove redundant logic #3390

Merged
merged 1 commit into from
Sep 16, 2017

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 15, 2017

The verify-gendocs target in the Makefile checks for the existence of the kops binary. By making the kops binary a dependency, this check need not exist.

I've silenced the commands in this target by prepending them with @, so all that the end-user sees is the echoed text, not the shell logic.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2017
@alrs
Copy link
Contributor Author

alrs commented Sep 15, 2017

/approve
/assign chrislovecnm

Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question of the year. Did you change a flag in create or something, and test that this works?

I am sure it does, but you makefile kungfu is stronger than mine

@alrs
Copy link
Contributor Author

alrs commented Sep 15, 2017

@chrislovecnm What is create? To test this, I do a make clean and then a make verify-gendocs, which causes the kops and the go-bindata targets to be built, and then verifies the cli docs. To test that it can detect a stale docs/cli I've been deleting docs/cli/kops.md and re-running make verify-gendocs, and it correctly notes that kops.md only exists in the /tmp directory.

@chrislovecnm
Copy link
Contributor

That will work!

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alrs, chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0224883 into kubernetes:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants