-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile remove redundant logic #3390
Makefile remove redundant logic #3390
Conversation
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb question of the year. Did you change a flag in create or something, and test that this works?
I am sure it does, but you makefile kungfu is stronger than mine
@chrislovecnm What is create? To test this, I do a |
That will work! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alrs, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
The
verify-gendocs
target in the Makefile checks for the existence of the kops binary. By making the kops binary a dependency, this check need not exist.I've silenced the commands in this target by prepending them with
@
, so all that the end-user sees is the echoed text, not the shell logic.