Add permissions for cluster autoscaler addon to scale down #3419
Conversation
Cluster autoscaler had insufficient permissions for the actions to scale down. fixes kubernetes#3418
|
Hi @johanhubens. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
needs-ok-to-test
|
/assign @kris-nova |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign andrewsykim If you could be so kind |
|
/lgtm Shocked that this ever worked without these permissions, or that no one bothered to report the issue til now :P |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. . |
This updates the autoscaler to 1.0.3, and adds a few new permissions that were implemented by Kops: * kubernetes/kops#3145 - Fixing clusterautoscaler rbac. * kubernetes/kops#3419 - Allow cluster autoscaler to scale down.
…2776) This updates the autoscaler to 1.0.3, and adds a few new permissions that were implemented by Kops: * kubernetes/kops#3145 - Fixing clusterautoscaler rbac. * kubernetes/kops#3419 - Allow cluster autoscaler to scale down.
Cluster autoscaler had insufficient permissions for the actions to scale down. fixes #3418