Makefile kops-install default

[alrs]

Makefile binary targets depend on SOURCES

I botched an attempt to merge master into the previous PR, so here is a do-over.

make will install the kops binary in $GOPATH/bin by default.

The binary targets all depend on the ${SOURCES} variable, so they will be rebuilt whenever any .go file in the tree is modified.

There was a concern in the previous PR from @chrislovecnm about missing .PHONY declarations. .PHONY is only needed for targets that aren't named after the artifact they create. Do you see any examples of .PHONY targets that aren't maked as such?

[alrs]

/approve /assign chrislovecnm

[justinsb]

Is go build still much slower than go install?

[justinsb]

@alrs the reason we've used PHONY for targets is because it's hard to compute the set of dependencies for a go program, and go install does a really good job. Unless we're going to declare all the dependencies, we need PHONY for a target with the same name as the output file. Or am I missing a trick?

[alrs]

@justinsb The SOURCES variable is a list of all .go extension files in the tree. If any of them change the non-PHONY binary targets will be rebuilt on a subsequent run of make.

[justinsb]

This needs .PHONY or some deps

[justinsb]

OK, I still think we might need some more deps but I'm going to get this merged along with the others so we can have a look.

BTW, @alrs have you check out bazel - once I saw bazel I kinda felt that as long as the makefile worked, that was good enough - the future is coming! Now if only they didn't keep breaking it ;-)

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alrs, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. .