New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map docker 1.13.1 & 17.03.1, default 1.8 to 1.13.1 #3462
Map docker 1.13.1 & 17.03.1, default 1.8 to 1.13.1 #3462
Conversation
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
According to https://github.com/kubernetes/features/blob/master/release-1.8/release-notes-draft.md#external-dependencies k8s was tested against 17.03.2, which seems to have some fixes on top of https://github.com/moby/moby/blob/1.13.x/CHANGELOG.md Maybe a better default? |
Pending some questions about the rev |
859f987
to
14000c1
Compare
/lgtm |
Going to remove LGTM, I'm actually not sure whether we should default to 1.13 or 17.03. I think GCE is going to stick with the COS image that has 1.13. Unsure what GKE is going to do. |
@dchen1107 any recommendations? |
/retest |
Kubernetes 1.8 is validated with 1.13.1 and 17.03.2. For 1.8, the default should be 1.13.1
14000c1
to
cc559dc
Compare
Default should be 1.13.1 for 1.8; updated PR |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Kubernetes 1.8 adds validation for 1.13.1 and 17.03.1 (17.03.1 being
essentially the same as 1.13.1).
For 1.8, the default should be 1.13.1