Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map docker 1.13.1 & 17.03.1, default 1.8 to 1.13.1 #3462

Merged

Conversation

justinsb
Copy link
Member

Kubernetes 1.8 adds validation for 1.13.1 and 17.03.1 (17.03.1 being
essentially the same as 1.13.1).

For 1.8, the default should be 1.13.1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2017
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@johanneswuerbach
Copy link
Contributor

@chrislovecnm chrislovecnm removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2017
@chrislovecnm
Copy link
Contributor

Pending some questions about the rev

@justinsb justinsb force-pushed the map_docker_1_13_1_17_03_1 branch 3 times, most recently from 859f987 to 14000c1 Compare September 30, 2017 06:10
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2017
@chrislovecnm chrislovecnm added this to the 1.8.0 milestone Sep 30, 2017
@justinsb
Copy link
Member Author

Going to remove LGTM, I'm actually not sure whether we should default to 1.13 or 17.03. I think GCE is going to stick with the COS image that has 1.13. Unsure what GKE is going to do.

@justinsb justinsb removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2017
@chrislovecnm
Copy link
Contributor

@dchen1107 any recommendations?

@chrislovecnm
Copy link
Contributor

/retest

Kubernetes 1.8 is validated with 1.13.1 and 17.03.2.

For 1.8, the default should be 1.13.1
@justinsb
Copy link
Member Author

justinsb commented Oct 3, 2017

Default should be 1.13.1 for 1.8; updated PR

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. blocks-next cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants