Fixing stdout on tests - cleaning house #3474
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @alrs If you could review |
|
/approve |
k8s-github-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
| @@ -163,7 +163,6 @@ F` | |||
| // We do need to cleanup, as otherwise we get some spurious changes on complex diffs | |||
| diffs = dmp.DiffCleanupSemantic(diffs) | |||
|
|
|||
| t.Logf("diffs %v", diffs) | |||
There was a problem hiding this comment.
Ah - actually - this one is so that we can see the actual diff in the case that the test fails.
We choose to then set -v, which is why the results appear, but that is correct.
There was a problem hiding this comment.
shouldn't we be only outputting the log if we fail??
There was a problem hiding this comment.
I thought that's how go test worked by default. But let's get this merged..
|
(removing LGTM - t.Logf is correct) |
justinsb
removed
the
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
We are printing to STDOUT and logging in some tests. Not needed.