bumping k8s versions in test files #3477
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/approve |
k8s-github-robot
added
the
approved
chrislovecnm
force-pushed
the
update-test-yaml-k8s-version
branch
from
6a0d3c5
to
df9f621
Compare
k8s-ci-robot
added
size/XXL
cmd/kops/integration_test.go
Outdated
| @@ -73,7 +73,7 @@ func TestComplex(t *testing.T) { | |||
| func TestMinimalCloudformation(t *testing.T) { | |||
| //runTestCloudformation(t, "minimal.example.com", "../../tests/integration/minimal", "v1alpha0", false) | |||
| //runTestCloudformation(t, "minimal.example.com", "../../tests/integration/minimal", "v1alpha1", false) | |||
| runTestCloudformation(t, "minimal.example.com", "../../tests/integration/minimal", "v1alpha2", false) | |||
| runTestCloudformation(t, "minimal.example.com", "../../tests/integration/cloudformation", "v1alpha2", false) | |||
There was a problem hiding this comment.
minimal is the only one where we actually test CF output - in theory we should test them all, but I'm not convinced it is worth it.
|
Do we have to split off the cloudformation directory? I don't understand why, and it isn't entirely right in that we actually should have a CF test in every dir, just that I think we get most of the value from a TF test |
|
/retest |
|
@chrislovecnm PR needs rebase |
k8s-github-robot
added
the
needs-rebase
chrislovecnm
force-pushed
the
update-test-yaml-k8s-version
branch
from
edffdb0
to
6aad3d8
Compare
k8s-github-robot
removed
the
needs-rebase
|
The other tests are far more flexible. For code maintainability breaking out the CF stuff makes sense in my head. Put the complex stuff into its own area, so a new developer is not trying to figure out which test is broken and why. I can move it back, but would rather iterate on it. I have another PR to bump the versions, which requires more edits to the CF stuff. It made sense to me to break it out, but I can put it back if it is a show stopper for you. |
chrislovecnm
force-pushed
the
update-test-yaml-k8s-version
branch
from
6aad3d8
to
5ed0d47
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
updating k8s versions in test YAML files so that we do not get warnings during testing