makefile: add 3 PHONY targets

[justinsb]

Marking some targets as phony that are plainly missing dependencies.

[chrislovecnm]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [chrislovecnm]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[justinsb]

/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[chrislovecnm]

@alrs btw

I1001 00:27:29.636] /bin/sh: 1: protoc: not found
I1001 00:27:29.636] Makefile:196: recipe for target 'protokube/pkg/gossip/mesh/mesh.pb.go' failed
I1001 00:27:29.637] make: *** [protokube/pkg/gossip/mesh/mesh.pb.go] Error 127
I1001 00:27:29.929] Makefile:360: recipe for target 'protokube-build-in-docker' failed

With adding the missing PHONY targes we are recreating the problem we saw in Travis

[chrislovecnm]

I have not idea how this is happenning, maybe docker version??? I am not able to recreate this locally.

[chrislovecnm]

Failed run https://gist.github.com/chrislovecnm/abce9404a0fb0f29dd3aaabfd2c2f11d

/retest

[alrs]

None of these three targets are PHONY, so I don't recommend doing this.

I'm making some progress in my own refactoring of the Makefile to deal with this issue, would you like me to put up a WIP so I can show you what I'm up to?

[alrs]

We know why this is happening: the Makefile thinks that protokube/pkg/gossip/mesh/mesh.pb.go either doesn't exist or is out-of-date, so it tries to rebuild it.

This could be because of:

1. Filesystem times are incorrect and make thinks that something is out-of-date when it isn't
2. make is being run outside of the root of the project, and wherever it goes looking for 'protokube/pkg/gossip/mesh/mesh.pb.go' it fails to find it, so it attempts to build it, which it can't, because there is no protoc.

[alrs]

It's really tough in this Makefile to figure out when things are happening on the host, in a container, and from which directory. I'm trying to refactor the Makefile so that make is only invoked from the host, the docker containers are set to run with /go/src/k8s.io/kops as the pwd.

[alrs]

Here's a wip-branch that is apropos to this conversation: #3505

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue.