-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wget for download, not just curl #3490
Support wget for download, not just curl #3490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note
pkg/model/resources/nodeup.go
Outdated
if ! curl -f --ipv4 -Lo "${file}" --connect-timeout 20 --retry 6 --retry-delay 10 "${url}"; then | ||
echo "== Failed to download ${url}. Retrying. ==" | ||
|
||
if [[ $(which curl) ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note. We need to allow for s3cmd and gs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both can do signed URLs.
CI is not passing |
00bbc03
to
c135402
Compare
Some images don't include curl but do have wget. Prefer curl, but fallback to wget. (The official Debian 9 image does not have curl.)
c135402
to
eb2cd45
Compare
Fixed CI :-) |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Some images don't include curl but do have wget. Prefer curl, but
fallback to wget.
(The official Debian 9 image does not have curl.)