Tweak signature in #3478 #3496
Merged
Tweak signature in #3478 #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Tweak for signature in #3478 cc @chrislovecnm |
chrislovecnm
approved these changes
Sep 30, 2017
|
Waiting on #3478 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-github-robot
added
the
approved
|
/retest |
|
/lgtm cancel need to fix unit test |
k8s-ci-robot
removed
the
lgtm
k8s-github-robot
removed
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel Unit test is failing - rebase please |
k8s-ci-robot
removed
the
lgtm
justinsb
force-pushed
the
using-same-disk-size-refactor
branch
from
cc79fc6
to
3f6d880
Compare
Because the default doesn't depend on the user-specified value, it's misleading to pass it in.
justinsb
force-pushed
the
using-same-disk-size-refactor
branch
from
3f6d880
to
66b1743
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #3478
Because the default doesn't depend on the user-specified value, it's
misleading to pass it in.