Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial bazel support #3510

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Initial bazel support #3510

merged 2 commits into from
Oct 3, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Oct 2, 2017

Builds on the 1.8 version bump

The "trick" is to strip the BUILD & BUILD.bazel files from the vendor-ed deps.

Will rebase after 1.8 version bump merges.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2017
@justinsb
Copy link
Member Author

justinsb commented Oct 2, 2017

cc @chrislovecnm and @alrs ... it's alive :-)

@chrislovecnm
Copy link
Contributor

WAHOO ... The 1.8 version bump is in the merge queue now

@chrislovecnm
Copy link
Contributor

we will need the hack scripts for maintaining and validating the bazel files. Will create issue.

@alrs
Copy link
Contributor

alrs commented Oct 2, 2017

Congrats!

@justinsb
Copy link
Member Author

justinsb commented Oct 2, 2017 •
edited
Loading

Still lots of work needed ... this is really just the bare minimum. But rebased so should be cleaner now. Second commit is all autogen, first commit is the interesting stuff.

@chrislovecnm
Copy link
Contributor

Can we rebase and get this in? Would like to start adding some TLC with hack files and such.

@justinsb
Copy link
Member Author

justinsb commented Oct 3, 2017

It is rebased @chrislovecnm ...

@justinsb justinsb changed the title WIP: bazel support Initial bazel support Oct 3, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2017
@chrislovecnm
Copy link
Contributor

/lgmt

chrislovecnm
chrislovecnm approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to review 3k files. Let's get this in :P

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 518e97d into kubernetes:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinsb @chrislovecnm @alrs @k8s-github-robot @k8s-ci-robot