Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix silly typo #3513

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Fix silly typo #3513

merged 1 commit into from
Oct 3, 2017

Conversation

mikesplain
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mikesplain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2017
@justinsb
Copy link
Member

justinsb commented Oct 3, 2017

/ok-to-test

/lgtm

Thanks for fixing - surprised our boilerplate checker didn't catch it!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 29d946c into kubernetes:master Oct 3, 2017
@mikesplain mikesplain mentioned this pull request Oct 8, 2017
Merged
4 tasks
k8s-github-robot pushed a commit that referenced this pull request Oct 9, 2017
Merge pull request #3564 from mikesplain/1.7_update_kube-dns
c2566e7 
Automatic merge from submit-queue.

Cherry Pick of 3511: Update kube-dns to 1.14.5 for CVE-2017-14491

Backport of #3511, #3513, #3538 to 1.7.

Testing:

- [x] 1.7.2
- [x] 1.6.6
- [x] 1.5.7
- [x] 1.4.12
@mikesplain mikesplain deleted the fix_typo branch October 9, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikesplain @k8s-ci-robot @justinsb @k8s-github-robot