-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE: Fix subnets vs zones formatting of instance groups #3524
GCE: Fix subnets vs zones formatting of instance groups #3524
Conversation
5045fdb
to
3e63928
Compare
3e63928
to
38ea16a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question ;)
@@ -65,6 +65,7 @@ k8s.io/kops/pkg/dns | |||
k8s.io/kops/pkg/edit | |||
k8s.io/kops/pkg/featureflag | |||
k8s.io/kops/pkg/flagbuilder | |||
k8s.io/kops/pkg/formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pkg? Can we put it in instancegroups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we would start putting all the formatter functionality into this package. And we've seen that comingling packages doesn't work in go - eventually the circular dependency catches up with you :-)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
No description provided.