Newer versions of docker do not follow Semantic Versioning

[rdrgmnzs]

Newer versions of docker do not follow Semantic Versioning. When selecting docker version 17.03.2 the following error occurs.

main.go:141] got error running nodeup (will retry in 30s): error building loader: error parsing docker version "17.03.2" as semver: Minor number must not contain leading zeroes 03

[k8s-ci-robot]

Hi @brdude. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chrislovecnm]

/ok-to-test

[rdrgmnzs]

/assign @chrislovecnm

[justinsb]

Good point! One option long term might be write a more relaxed parser for parsing the docker version, as I think it is probably still "semver compatible" even if it doesn't follow the semver rules. (One simple option might be to simply to strip any leading zeroes). But I like what you've done here!

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue.