bazel versions of test, build, push-aws-run & push-gce-run #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are developer-oriented targets, so they seem like a good place to start.
k8s-ci-robot
added
cncf-cla: yes
mikesplain
reviewed
Oct 10, 2017
| bazel-crossbuild-nodeup: | ||
| bazel build //cmd/nodeup | ||
|
|
||
| .PHONY: push |
There was a problem hiding this comment.
I can lgtm this and you can follow-up?
|
/lgtm @mikesplain will follow-up with the tweak |
k8s-ci-robot
added
the
lgtm
chrislovecnm
approved these changes
Oct 10, 2017
k8s-github-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, mikesplain The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
mikesplain
added a commit
to mikesplain/kops
that referenced
this pull request
Oct 10, 2017
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are developer-oriented targets, so they seem like a good place
to start.