-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing bazel testing for upup #3660
fixing bazel testing for upup #3660
Conversation
/assign @andrewsykim |
/assign @justinsb @gambol99 @andrewsykim @KashifSaadat any of you guys know bazel? Trying to figure out if someone else can review these other than just @justinsb |
@@ -103,4 +103,7 @@ go_test( | |||
"//vendor/github.com/golang/glog:go_default_library", | |||
"//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library", | |||
], | |||
data = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were autogenerated right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing stuff no. Gazelle will fix dependencies and stuff.
/lgtm Thanks for fixing! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Fixes: #3626