Improving UX for placeholder IP Address #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Fixes: #2679 |
Before the `kops validate cluster` attempts to connect to the K8s API endpoint, the code now checks to see if the API DNS Entry is the kops placeholder IP Address 203.0.113.123. It prints a message to the user and err's. There is a new init func in validate cluster that disables CGO based DNS for Darwin OS. Darwin does two things with kops validates; it caches the IP address, and it does not return the placeholder IP address. We cannot use CGO base DNS with kops validate.
chrislovecnm
force-pushed
the
placehold-dns-ux-updates
branch
from
fe30482
to
c7ef856
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrislovecnm
changed the title
|
/assign @justinsb @KashifSaadat @andrewsykim |
|
/approve |
k8s-ci-robot
added
the
approved
chrislovecnm
commented
Nov 16, 2017
| if hasPlaceHolderIPAddress { | ||
| fmt.Println( | ||
| "Validation Failed\n\n" + | ||
| "The dns-controller Kubernetes deployment has not updated the Kubernetes cluster's API DNS entry to the correct IP address." + |
There was a problem hiding this comment.
Need a good proof read on this please
|
Tested, working and message looks sensible. 👍 /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, KashifSaadat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the
kops validate clusterattempts to connect to the K8s APIendpoint, the code now checks to see if the API DNS Entry is the kops
placeholder IP Address 203.0.113.123. It prints a message to the user
and err's. There is a new init func in validate cluster that disables
CGO based DNS for Darwin OS. Darwin does two things with kops
validates; it caches the IP address, and it does not return the
placeholder IP address. We cannot use CGO base DNS with kops validate with OSX.