-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DeleteResources into pkg/resources/utils #3720
Move DeleteResources into pkg/resources/utils #3720
Conversation
This will enable log collection even if nodes don't register. AWS: Dumps ids & addresses GCE: Dumps names - addresses to follow Others: Not yet!
Builds on #3719 |
utils? Can we pick another name? You are good with names |
That seems to be what utils really is.
@chrislovecnm - done! renamed utils to ops - seems more fitting for what it is now! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
No description provided.