New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate errors from Find for tasks with WarnIfInsufficientAccess #3728
Tolerate errors from Find for tasks with WarnIfInsufficientAccess #3728
Conversation
@chrislovecnm I think you'll like this ... this is how I envisaged we would tolerate errors for just-validate tasks - we're just glog.Warning at the moment, but starting to collect warnings as well for a future structured presentation. Should also help with GCE ... we don't have the ACL permissions either :-( But it's a good test case for locked-down environments. I don't like defaulting to WarnIfInsufficientAccess for this task, but it's better than the immediate alternative which is just ripping it out entirely. If this works out, I think I'll tweak it so that the e2e tests opt in to WarnIfInsufficientAccess eventually (though I haven't fully thought that through yet!) |
We glog.Warning a message, and we record a structured warning for future use, but we allow operation to continue.
2a8a6b2
to
2eb47b8
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
We glog.Warning a message, and we record a structured warning for future
use, but we allow operation to continue.