Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate errors from Find for tasks with WarnIfInsufficientAccess #3728

Merged
merged 1 commit into from Oct 30, 2017

Conversation

justinsb
Copy link
Member

We glog.Warning a message, and we record a structured warning for future
use, but we allow operation to continue.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2017
@justinsb
Copy link
Member Author

justinsb commented Oct 30, 2017

@chrislovecnm I think you'll like this ... this is how I envisaged we would tolerate errors for just-validate tasks - we're just glog.Warning at the moment, but starting to collect warnings as well for a future structured presentation.

Should also help with GCE ... we don't have the ACL permissions either :-(
https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-gce/406/build-log.txt

But it's a good test case for locked-down environments. I don't like defaulting to WarnIfInsufficientAccess for this task, but it's better than the immediate alternative which is just ripping it out entirely. If this works out, I think I'll tweak it so that the e2e tests opt in to WarnIfInsufficientAccess eventually (though I haven't fully thought that through yet!)

We glog.Warning a message, and we record a structured warning for future
use, but we allow operation to continue.
@justinsb justinsb changed the title Tolerate errors from Find for tasks with LifecycleExistsAndWarnIfChanges Tolerate errors from Find for tasks with WarnIfInsufficientAccess Oct 30, 2017
@justinsb
Copy link
Member Author

/retest

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit adbcaac into kubernetes:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants