Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gophercloud to the newest version #3744

Merged

Conversation

zengchen1024
Copy link
Contributor

@zengchen1024 zengchen1024 commented Oct 31, 2017

The current version of 'gophercloud' may not work well to parse the identity endpoint such as 'https://${ip}/identity', and will be broken when creating a new client of 'ProviderClient' by passing an endpoint like that. However, the newest version of 'gophcloud' works well.
Which issue this PR fixes: #3676

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zengchen1024. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2017
@zengchen1024
Copy link
Contributor Author

/cc @justinsb Please take a look at this PR! Thanks!

@zengchen1024
Copy link
Contributor Author

/assign @zengchen1024

@suramya-shah
Copy link

/retest

@k8s-ci-robot
Copy link
Contributor

@ss22ever: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Member

/retest

@chrislovecnm
Copy link
Contributor

/ok-to-tesf

@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2017
@justinsb
Copy link
Member

justinsb commented Nov 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@justinsb
Copy link
Member

justinsb commented Nov 1, 2017

Thanks @zengchen1024 - FYI, upstream k8s is on 443743e88335413103dcf1997e46d401b264fbcd at master, so we're jumping a little ahead of upstream (and I have no problem with doing so). I imagine this will sort itself out by the k8s 1.9 anyway - we typically sync up our versions at each major k8s release.

@zengchen1024
Copy link
Contributor Author

@justinsb Thanks for promoting this PR. By the way, do I need to follow the upstream k8s if I update the other dependency next time?

@zengchen1024
Copy link
Contributor Author

@justinsb My question is the upstream k8s may have not updated its dependency when I want to update it on kops. So I don't know which version will k8s update to. What should I do for this case? Thanks

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit ed575a2 into kubernetes:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement VFS with Openstack Swift
6 participants