-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gophercloud to the newest version #3744
update gophercloud to the newest version #3744
Conversation
Hi @zengchen1024. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @justinsb Please take a look at this PR! Thanks! |
/assign @zengchen1024 |
/retest |
@ss22ever: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/ok-to-tesf |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Thanks @zengchen1024 - FYI, upstream k8s is on 443743e88335413103dcf1997e46d401b264fbcd at master, so we're jumping a little ahead of upstream (and I have no problem with doing so). I imagine this will sort itself out by the k8s 1.9 anyway - we typically sync up our versions at each major k8s release. |
@justinsb Thanks for promoting this PR. By the way, do I need to follow the upstream k8s if I update the other dependency next time? |
@justinsb My question is the upstream k8s may have not updated its dependency when I want to update it on kops. So I don't know which version will k8s update to. What should I do for this case? Thanks |
Automatic merge from submit-queue. |
The current version of 'gophercloud' may not work well to parse the identity endpoint such as 'https://${ip}/identity', and will be broken when creating a new client of 'ProviderClient' by passing an endpoint like that. However, the newest version of 'gophcloud' works well.
Which issue this PR fixes: #3676