Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding -y #3767

Merged
merged 1 commit into from Nov 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/kops/create_cluster.go
Expand Up @@ -237,7 +237,7 @@ func NewCmdCreateCluster(f *util.Factory, out io.Writer) *cobra.Command {
},
}

cmd.Flags().BoolVar(&options.Yes, "yes", options.Yes, "Specify --yes to immediately create the cluster")
cmd.Flags().BoolVarP(&options.Yes, "yes", "y", options.Yes, "Specify --yes to immediately create the cluster")
cmd.Flags().StringVar(&options.Target, "target", options.Target, fmt.Sprintf("Valid targets: %s, %s, %s. Set this flag to %s if you want kops to generate terraform", cloudup.TargetDirect, cloudup.TargetTerraform, cloudup.TargetDirect, cloudup.TargetTerraform))
cmd.Flags().StringVar(&options.Models, "model", options.Models, "Models to apply (separate multiple models with commas)")

Expand Down
2 changes: 1 addition & 1 deletion cmd/kops/rollingupdatecluster.go
Expand Up @@ -164,7 +164,7 @@ func NewCmdRollingUpdateCluster(f *util.Factory, out io.Writer) *cobra.Command {
Example: rollingupdate_example,
}

cmd.Flags().BoolVar(&options.Yes, "yes", options.Yes, "perform rolling update without confirmation")
cmd.Flags().BoolVarP(&options.Yes, "yes", "y", options.Yes, "Perform rolling update immediately, without --yes rolling-update executes a dry-run")
cmd.Flags().BoolVar(&options.Force, "force", options.Force, "Force rolling update, even if no changes")
cmd.Flags().BoolVar(&options.CloudOnly, "cloudonly", options.CloudOnly, "Perform rolling update without confirming progress with k8s")

Expand Down
2 changes: 1 addition & 1 deletion cmd/kops/update_cluster.go
Expand Up @@ -102,7 +102,7 @@ func NewCmdUpdateCluster(f *util.Factory, out io.Writer) *cobra.Command {
},
}

cmd.Flags().BoolVar(&options.Yes, "yes", options.Yes, "Actually create cloud resources")
cmd.Flags().BoolVarP(&options.Yes, "yes", "y", options.Yes, "Create cloud resources, without --yes update is in dry run mode")
cmd.Flags().StringVar(&options.Target, "target", options.Target, "Target - direct, terraform, cloudformation")
cmd.Flags().StringVar(&options.Models, "model", options.Models, "Models to apply (separate multiple models with commas)")
cmd.Flags().StringVar(&options.SSHPublicKey, "ssh-public-key", options.SSHPublicKey, "SSH public key to use (deprecated: use kops create secret instead)")
Expand Down
2 changes: 1 addition & 1 deletion cmd/kops/update_federation.go
Expand Up @@ -34,7 +34,7 @@ var (

update_federation_example = templates.Examples(i18n.T(`
# After cluster has been edited or upgraded, configure it with:
kops update federation k8s-cluster.example.com --yes --state=s3://kops-state-1234 --yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep at least one --yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no --yes on the options object unless I missed it

kops update federation k8s-cluster.example.com --state=s3://kops-state-1234
`))

update_federation_short = i18n.T("Update federation cluster resources.")
Expand Down
2 changes: 1 addition & 1 deletion docs/cli/kops_create_cluster.md
Expand Up @@ -101,7 +101,7 @@ kops create cluster
--target string Valid targets: direct, terraform, direct. Set this flag to terraform if you want kops to generate terraform (default "direct")
-t, --topology string Controls network topology for the cluster. public|private. Default is 'public'. (default "public")
--vpc string Set to use a shared VPC
--yes Specify --yes to immediately create the cluster
-y, --yes Specify --yes to immediately create the cluster
--zones stringSlice Zones in which to run the cluster
```

Expand Down
2 changes: 1 addition & 1 deletion docs/cli/kops_rolling-update_cluster.md
Expand Up @@ -76,7 +76,7 @@ kops rolling-update cluster
--instance-group stringSlice List of instance groups to update (defaults to all if not specified)
--master-interval duration Time to wait between restarting masters (default 5m0s)
--node-interval duration Time to wait between restarting nodes (default 4m0s)
--yes perform rolling update without confirmation
-y, --yes Perform rolling update immediately, without --yes rolling-update executes a dry-run
```

### Options inherited from parent commands
Expand Down
2 changes: 1 addition & 1 deletion docs/cli/kops_update_cluster.md
Expand Up @@ -32,7 +32,7 @@ kops update cluster
--phase string Subset of tasks to run: assets, cluster, network, security
--ssh-public-key string SSH public key to use (deprecated: use kops create secret instead)
--target string Target - direct, terraform, cloudformation (default "direct")
--yes Actually create cloud resources
-y, --yes Create cloud resources, without --yes update is in dry run mode
```

### Options inherited from parent commands
Expand Down
2 changes: 1 addition & 1 deletion docs/cli/kops_update_federation.md
Expand Up @@ -18,7 +18,7 @@ kops update federation

```
# After cluster has been edited or upgraded, configure it with:
kops update federation k8s-cluster.example.com --yes --state=s3://kops-state-1234 --yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, did you mean to leave 1 --yes?

kops update federation k8s-cluster.example.com --state=s3://kops-state-1234
```

### Options inherited from parent commands
Expand Down