-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows kops.exe binary support #3770
Conversation
01506e6
to
5905aa2
Compare
return changed, fmt.Errorf("error looking up group %q: %v", groupName, err) | ||
} | ||
|
||
if int(stat.Sys().(*syscall.Stat_t).Uid) == user.Uid && int(stat.Sys().(*syscall.Stat_t).Gid) == group.Gid { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*syscall.Stat_t.Uid
is not supported on windows.
@@ -0,0 +1,58 @@ | |||
// +build !windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't build this if we are compiling for windows. This code is only used by nodeup
.
[submodule "_vendor/github.com/Sirupsen/logrus"] | ||
path = _vendor/github.com/Sirupsen/logrus | ||
url = https://github.com/Sirupsen/logrus | ||
[submodule "_vendor/github.com/sirupsen/logrus"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker code that compiles under windows has the import as sirupsen not Sirupsen. Otherwise it does not seem to have broken anything.
Fixes: #3635 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Initial support for windows. Hey, it compiles. We need more testing, I have not tested it on my windows laptop yet.
/assign @justinsb
Fixes: #722
Summary
EnsureFileOwner
into its own go file, and not have it compiled for windows. It is only used by nodeup. This is the only code change.