-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for latest bazel / vendor #3781
Conversation
48c9e08
to
c215804
Compare
I am getting:
And when I fix the path adding
|
After fixing some path issues |
Also you are adding back |
fixed the errors before this. see chrislovecnm@73be9c3 But now getting this error: bazel build //cmd/... //pkg/... //channels/... //nodeup/... //channels/... //protokube/... //dns-controller/...
ERROR: /Users/clove/Workspace/src/k8s.io/kops/protokube/pkg/gossip/mesh/BUILD.bazel:36:12: in deps attribute of go_proto_library rule //protokube/pkg/gossip/mesh:mesh_go_proto: '//vendor/github.com/gogo/protobuf/gogoproto:gogoproto_proto' does not have mandatory providers: 'GoLibrary'.
ERROR: Analysis of target '//dns-controller/cmd/dns-controller:dns-controller' failed; build aborted: Analysis of target '//protokube/pkg/gossip/mesh:mesh_go_proto' failed; build aborted.
INFO: Elapsed time: 0.333s
make: *** [bazel-build] Error 1 |
Symlinking confuses gazelle
We don't want it generating protobuf rules in our vendor directory
We want to ignore proto in vendor, but not in our code.
Doesn't seem to build with that attribute
We're still checking in the generated pb.go file, for now.
c215804
to
67b434f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
No description provided.