Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for latest bazel / vendor #3781

Merged
merged 10 commits into from
Nov 6, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Nov 6, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2017
@justinsb justinsb force-pushed the fix_bazel_build branch 2 times, most recently from 48c9e08 to c215804 Compare November 6, 2017 20:12
@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 6, 2017

I am getting:

ERROR: /Users/clove/Workspace/src/k8s.io/kops/protokube/pkg/gossip/mesh/BUILD.bazel:23:1: no such package 'github.com/gogo/protobuf/gogoproto': BUILD file not found on package path and referenced by '//protokube/pkg/gossip/mesh:mesh_proto'.
ERROR: Analysis of target '//protokube/pkg/gossip/mesh:mesh_proto' failed; build aborted: no such package 'github.com/gogo/protobuf/gogoproto': BUILD file not found on package path.
INFO: Elapsed time: 5.296s
make: *** [bazel-build] Error 1

And when I fix the path adding vendor to it I get:

java.lang.IllegalStateException: CONFIGURED_TARGET://protokube/pkg/gossip/mesh:mesh_go_proto 5df58ca576fbb2626b32a127fb720224 (1302491513 790108584) -> <ErrorInfo exception=com.google.devtools.build.lib.skyframe.ToolchainResolutionFunction$NoToolchainFoundException: no matching toolchain found for @io_bazel_rules_go//proto:proto rootCauses={ToolchainResolutionKey{configuration=5df58ca576fbb2626b32a127fb720224, toolchainType=@io_bazel_rules_go//proto:proto

@chrislovecnm
Copy link
Contributor

ERROR: /Users/clove/Workspace/src/k8s.io/kops/protokube/pkg/gossip/mesh/BUILD.bazel:36:12: in deps attribute of go_proto_library rule //protokube/pkg/gossip/mesh:mesh_go_proto: '//vendor/github.com/gogo/protobuf/gogoproto:gogoproto_proto' does not have mandatory providers: 'GoLibrary'.

After fixing some path issues

@chrislovecnm
Copy link
Contributor

Also you are adding back vendor/github.com/Sirupsen

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 6, 2017

fixed the errors before this. see chrislovecnm@73be9c3

But now getting this error:

bazel build //cmd/... //pkg/... //channels/... //nodeup/... //channels/... //protokube/... //dns-controller/...
ERROR: /Users/clove/Workspace/src/k8s.io/kops/protokube/pkg/gossip/mesh/BUILD.bazel:36:12: in deps attribute of go_proto_library rule //protokube/pkg/gossip/mesh:mesh_go_proto: '//vendor/github.com/gogo/protobuf/gogoproto:gogoproto_proto' does not have mandatory providers: 'GoLibrary'.
ERROR: Analysis of target '//dns-controller/cmd/dns-controller:dns-controller' failed; build aborted: Analysis of target '//protokube/pkg/gossip/mesh:mesh_go_proto' failed; build aborted.
INFO: Elapsed time: 0.333s
make: *** [bazel-build] Error 1

Symlinking confuses gazelle
We don't want it generating protobuf rules in our vendor directory
We want to ignore proto in vendor, but not in our code.
Doesn't seem to build with that attribute
We're still checking in the generated pb.go file, for now.
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f71b94e into kubernetes:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants