Bugfix kops update always detecting changes when using ExecContainerAction. #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en HookSpecs have ExecContainerAction defined.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @chrislovecnm @justinsb @gambol99 |
|
Any word @blakebarnett |
|
First test worked, need to setup the exact same scenario again to re-verify. |
|
👍 LGTM |
chrislovecnm
approved these changes
Nov 8, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test pull-kops-e2e-kubernetes-aws |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecContainerActionis referenced as a pointer in theHookSpec. When the bootstrapscript is run, it fingerprints the content here and stores it on-top of the existingExecContainerActionwithin the Hook being parsed. The bootstrapscript is called for every Instance Group, and so the fingerprinted content gets passed and re-parsed.This PR fixes the issue by creating a new
ExecContainerActionobject and assigning it to the hook being processed. Tests should now cover this case by running theResourceNodeUpfn multiple times.Fixes #3516