Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for C5 instance family #3794

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Add support for C5 instance family #3794

merged 2 commits into from
Nov 10, 2017

Conversation

shamil
Copy link
Contributor

@shamil shamil commented Nov 8, 2017

AWS released 5th generation of Compute oriented EC2 series. This PR adds support for them.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
Copy link
Contributor

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@KashifSaadat
Copy link
Contributor

Just need to fmt the machine_types.go file:

hack/verify-gofmt.sh
!!! 'gofmt -s -w' needs to be run on the following files: 
upup/pkg/fi/cloudup/awsup/machine_types.go

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2017
@chrislovecnm
Copy link
Contributor

Fixes: #3788

@barnybug
Copy link

barnybug commented Nov 8, 2017

@shamil out of interest, what base image are you using on c5 instances? The k8s-1.7-debian-jessie lacks ENA support, and the stock Ubuntu image networking seemed unreliable.

@shamil
Copy link
Contributor Author

shamil commented Nov 8, 2017

@barnybug we use C5 family in our test cluster. For that purpose we created our own AMI based on k8s-1.7-debian-jessie-amd64-hvm-ebs-2017-07-28 image.

I followed the official guide for adding ena support: http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/enhanced-networking-ena.html

here is the output of the ethtool command

root@packer-test:~# uname -svr && ethtool -i eth0
Linux 4.4.78-k8s #1 SMP Fri Jul 28 01:28:39 UTC 2017
driver: ena
version: 1.3.0g
firmware-version: 
bus-info: 0000:00:05.0
supports-statistics: yes
supports-test: no
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: no

@shamil
Copy link
Contributor Author

shamil commented Nov 8, 2017

/retest

@felipejfc
Copy link
Contributor

felipejfc commented Nov 9, 2017

I guess that for this to be merged we should also change kops to use an image with ENA enabled when using c5 family.

#3788

@barnybug
Copy link

barnybug commented Nov 9, 2017

@shamil thanks for the info. In the end we used the coreos pre-built images which support ena (https://coreos.com/dist/aws/aws-stable.json).

@justinsb
Copy link
Member

Awesome - thanks @shamil !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@shamil
Copy link
Contributor Author

shamil commented Nov 10, 2017

/retest

@shamil
Copy link
Contributor Author

shamil commented Nov 10, 2017

e2e failing, not sure it's because of this PR. I'll do retry one more time ...
/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit aab07e3 into kubernetes:master Nov 10, 2017
@shamil shamil deleted the patch-2 branch November 10, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants