-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for C5 instance family #3794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
Just need to fmt the machine_types.go file:
/ok-to-test |
Fixes: #3788 |
@shamil out of interest, what base image are you using on c5 instances? The k8s-1.7-debian-jessie lacks ENA support, and the stock Ubuntu image networking seemed unreliable. |
@barnybug we use I followed the official guide for adding here is the output of the
|
/retest |
I guess that for this to be merged we should also change kops to use an image with ENA enabled when using c5 family. |
@shamil thanks for the info. In the end we used the coreos pre-built images which support ena (https://coreos.com/dist/aws/aws-stable.json). |
Awesome - thanks @shamil ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
AWS released 5th generation of Compute oriented EC2 series. This PR adds support for them.